Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEY-2 Navigate between highlights #2

Merged
merged 17 commits into from
May 4, 2021

Conversation

Nitrooos
Copy link
Owner

For end user:

  • navigating between highlights using arrow keys
  • possibility to simulate 'click' event on given element by pressing Enter when proper highlight is selected

Technical summary:

  • remove highlightsModule, now showing/hiding highlights is the responsibility of domHighlightModule (it's the only one making operations on DOM)
  • create appModule, encapsulating all state and high-level operations, like 'toggleHighlights', 'navigateHighlights' and 'simulateClick'
  • created utilsModule with some very basic util functions
  • assign additional data to highlight objects: bounding client rect, original clickable element and the actual highlight element itself

@Nitrooos Nitrooos self-assigned this Apr 29, 2021
@Nitrooos Nitrooos merged commit 218a6c0 into master May 4, 2021
@Nitrooos Nitrooos deleted the KEY-2_navigate-between-highlights branch September 12, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant