fix: implement class #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vitia-fritelle
commented
Jun 16, 2022
vitia-fritelle
commented
- Configuração do prettier está como tabWidth e não como tabSize
- Convetido o CustomError de OO prototípica para OO clássica
- Fiz uma mudança no getUserById pare pegar com LEFT JOIN. Verificar se não dará conflito no de vocês.
- Eu coloquei um try-catch nos middlewares para debugar, acho que eles podem ser removidos dado que temos o módulo de express-async-errors, mas é necessário realizar os testes.
- Fiz algumas mudanças de arquitetura porque havia algumas pastas repetidas.
NivaldoFarias
approved these changes
Jun 16, 2022
| text: Joi.string(), | ||
| url: Joi.string().pattern(new RegExp(REG_URL)).required() | ||
| text: Joi.string(), | ||
| url: Joi.string().pattern(new RegExp(REG_URL)).required(), |
There was a problem hiding this comment.
Poderia utilizar o uri() do Joi ao invés da regex como alternativa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.