Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored files are not ignored when multiple folder inputs are given #25

Closed
Nixinova opened this issue Jul 1, 2023 · 3 comments
Closed
Labels
bug Something isn't working fixed This issue has been fixed

Comments

@Nixinova
Copy link
Owner

Nixinova commented Jul 1, 2023

Folders like .git etc are not ignored by default when multiple folder inputs are given (e.g. linguist -a folderA folderB).

# folderA
file.js
# folderB
.gitignore
ignored
notignored.txt
> (await linguist(['folderA'])).files.results
{
  'folderA/file.js': 'JavaScript'
}

> (await linguist(['folderB'])).files.results
{
  'folderB/notignored.txt': 'Text'
}

> (await linguist(['folderA','folderB'])).files.results
{
  'folderA/.git/config': null,
  'folderA/.git/description': null,
  // ... whole .git folder
  'folderA/file.js': 'JavaScript',
  'folderB/notignored.txt': 'Text'
  // NOT `ignored` - good, gitattributes works still
Example

Gitattributes is still read correctly however.

@Nixinova Nixinova added the bug Something isn't working label Jul 1, 2023
@Nixinova Nixinova added the fixed This issue has been fixed label Jul 1, 2023
@Nixinova
Copy link
Owner Author

Looks like using e.g. linguist -a -i foo triggers this issue as well

@Nixinova Nixinova reopened this Jul 23, 2023
@Nixinova Nixinova removed the fixed This issue has been fixed label Jul 23, 2023
@Nixinova
Copy link
Owner Author

Gitattributes seems not to be properly read.

@Nixinova
Copy link
Owner Author

Properly fixed now

@Nixinova Nixinova added the fixed This issue has been fixed label Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue has been fixed
Projects
None yet
Development

No branches or pull requests

1 participant