Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from the Node events module to eventemitter3 #140

Closed
wants to merge 1 commit into from

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Dec 5, 2020

This removes the need for a bundler to polyfill the Node events module in order to use web3-react.

We could also use the events module on npm, but eventemitter3 has a few advantages over it.

This removes the need for a bundler to polyfill the Node events modules
in order to use web3-react.
@NoahZinsmeister
Copy link
Contributor

in v8, nothing actually extends EventEmitter anymore, just the interface is imported: https://github.com/NoahZinsmeister/web3-react/blob/main/packages/types/src/index.ts#L1

so, hopefully this is a non-issue going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants