Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityLogging breaks login after Sorcery upgrade #465

Closed
zetlan opened this issue Oct 11, 2013 · 2 comments
Closed

ActivityLogging breaks login after Sorcery upgrade #465

zetlan opened this issue Oct 11, 2013 · 2 comments

Comments

@zetlan
Copy link

zetlan commented Oct 11, 2013

Not sure there's much to be done here, but I had an existing app running Sorcery 0.8.1. Following the upgrade to 0.8.2, I could no longer log in to the app. Root cause: Sorcery 0.8.2 included last_login_from_ip_address in the activity logging, but 0.8.1 did not. But since I was already using activity logging, 0.8.2 looked for the field, and couldn't find it.

I'm not sure whether I missed some kind of migration upgrade process, or whether it should have happened automatically, or what? Could Sorcery somehow detect it's been upgraded and generate the necessary migrations?

Anyway, solution was pretty simple – I created a migration that added the field, and all is well. And I see that the generators have been patched to include the field, so new installs of Sorcery 0.8.2 and later should be fine.

@kirs kirs closed this as completed in 2b4669b Oct 17, 2013
@kirs
Copy link
Collaborator

kirs commented Oct 17, 2013

Thanks for report. I've mentioned it in README and CHANGELOG.

@cserb
Copy link

cserb commented Jan 14, 2014

Totally uncool dude! This breaks compatibility with older versions and should be more like in a 0.9.x version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants