New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 200 rather than 404 if pagination out of range #10

Merged

lafrech merged 1 commit into master from dev_pagination_out_of_range_return_200

Sep 27, 2018

Member

lafrech commented Sep 26, 2018

On second thought, returning 200 seems better from a practical perspective.

For thoughts on this, see https://stackoverflow.com/questions/25724751/.

This changes makes things more consistent with the "empty collection" case.
It provides the client size of collection and available pages.
It makes the code simpler...

Obviously, this is a breaking change.


          Return 200 rather than 404 if pagination out of range

33722f6

coveralls commented Sep 26, 2018

Coverage decreased (-0.004%) to 99.632% when pulling 33722f6 on dev_pagination_out_of_range_return_200 into 24a2eeb on master.

lafrech merged commit 1584ea7 into master

lafrech deleted the dev_pagination_out_of_range_return_200 branch

September 27, 2018 19:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment