Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Meetup API credentials to an environmental variable. #29

Open
adunkman opened this issue Mar 9, 2015 · 2 comments
Open

Move Meetup API credentials to an environmental variable. #29

adunkman opened this issue Mar 9, 2015 · 2 comments

Comments

@adunkman
Copy link
Member

adunkman commented Mar 9, 2015

As per discussion on #27, we’re currently using Meetup’s signed URLs:

Similar to OAuth signing, this method of authentication certifies that a request was approved by a particular user. Unlike OAuth-signed requests, key-signed requests may be reused and recycled as long as their corresponding API key is valid. If a signed URL is released to the public, any application can use it to interact with Meetup as if it had that API key; the difference is that it can not change definitive parameters or use the signature against other API methods.

We should probably not be letting other people act on behalf of our API key long term, and instead be storing our API key in an environmental variable.

@adunkman
Copy link
Member Author

adunkman commented Mar 9, 2015

@joshfinnie
Copy link
Member

I went ahead and made the change in #27 since it wasn't merged in yet... We'll need to set MEETUPAPIKEY on heroku for deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants