Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN docker image version from github #507

Closed
BeroBurny opened this issue Feb 24, 2021 · 3 comments
Closed

BN docker image version from github #507

BeroBurny opened this issue Feb 24, 2021 · 3 comments
Assignees
Labels

Comments

@BeroBurny
Copy link
Collaborator

At the current state, we use the docker image version from env.
We want to change it to pull the image version from this repository to simplify updating versions of images if there are no breaking changes for the chain guardian

@BeroBurny BeroBurny added the enhancement New feature or request label Feb 24, 2021
@BeroBurny BeroBurny self-assigned this Mar 9, 2021
@mpetrunic
Copy link
Member

mpetrunic commented Mar 10, 2021

To clarify this issue:

Current proposed solution is not really nice as it requires us to keep updating version as new updates comes in (hard to keep up-to-date because of timezones) it also allows us (or attacker) to merge to master change which could swap lighthouse docker image with some malware to steal keys.

@BeroBurny
Copy link
Collaborator Author

it also allows us (or attacker) to merge to master change which could swap lighthouse docker image with some malware to steal keys.

us 😓 in that case, any solution is doomed

Current proposed solution is not really nice as it requires us to keep updating version as new updates come in (hard to keep up-to-date because of timezones)

and we goona need to update recommended version in the same way, we can not run away from this (it will be possible only when everything become standardized)

just want to avoid this as can be confused in 10 different version what is best? for some newbie probably the newest dispute of recommendations, as everyone recommends to use newest

probably the best will be some double mixed mega overkill 🗡️ solution 😄

@mpetrunic
Copy link
Member

mpetrunic commented Mar 10, 2021

it also allows us (or attacker) to merge to master change which could swap lighthouse docker image with some malware to steal keys.

us in that case, any solution is doomed

It's quite different to pull from master of our repo and to receive something in binary.

and we goona need to update recommended version in the same way, we can not run away from this (it will be possible only when everything become standardized)

If there is critical vulnerability, users can choose newer version immediately when released by client teams (those things rarely cause breaking change). As for regular versions we will have plenty of time to update recommended version and release new binary.

Consider there is some critical vulnerability that people discover while we are at work, we have to wait for client team in australia to release fix which would happen at night so it would pass ~24hours before user can bump version.

just want to avoid this as can be confused in 10 different version what is best? for some newbie probably the newest dispute of recommendations, as everyone recommends to use newest

Should be ordered with our recommended version highlighted and with (recommended) suffix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants