Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add validator loader on first add #524

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

BeroBurny
Copy link
Collaborator

Short description of work done

  • fix add validator loader on the first add

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Issues

Closes #521

@BeroBurny BeroBurny added the bug Something isn't working label Mar 4, 2021
@BeroBurny BeroBurny requested a review from a team as a code owner March 4, 2021 13:30
@BeroBurny BeroBurny self-assigned this Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #524 (ca0e50a) into master (36687a9) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   59.00%   59.03%   +0.03%     
==========================================
  Files          75       75              
  Lines        1244     1245       +1     
  Branches      146      146              
==========================================
+ Hits          734      735       +1     
  Misses        483      483              
  Partials       27       27              
Flag Coverage Δ
unit 59.03% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/services/docker/container.ts 9.83% <0.00%> (ø)
src/renderer/services/utils/logging/buffered.ts 89.28% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36687a9...5bd5bf2. Read the comment docs.

@mpetrunic mpetrunic merged commit 6ade25d into master Mar 4, 2021
@mpetrunic mpetrunic deleted the beroburny/add-new-validator-loader branch March 4, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added new validator but validator list display delayed
2 participants