Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beacon Node start/stop button #526

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Conversation

BeroBurny
Copy link
Collaborator

Short description of work done

  • fix start/stop button for beacon node
  • fix beacon node status in some cases show wrong data

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Issues

Closes #517

@BeroBurny BeroBurny requested a review from a team as a code owner March 8, 2021 09:26
@BeroBurny BeroBurny self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #526 (7e2f624) into master (0f36ef1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          75       75           
  Lines        1253     1253           
  Branches      148      148           
=======================================
  Hits          735      735           
  Misses        491      491           
  Partials       27       27           
Flag Coverage Δ
unit 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f36ef1...8ea32b4. Read the comment docs.

@BeroBurny BeroBurny added the bug Something isn't working label Mar 8, 2021
@mpetrunic mpetrunic merged commit 1396cc1 into master Mar 8, 2021
@mpetrunic mpetrunic deleted the beroburny/bn-start-button branch March 8, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start button visible before BN status is loaded
2 participants