Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images config from GitHub #532

Merged
merged 13 commits into from
Apr 9, 2021

Conversation

BeroBurny
Copy link
Collaborator

Short description of work done

  • implement config reader from github

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

  • implement config reader from github
  • refactor sagas to use docker image from config

Issues

Closes #507

@BeroBurny BeroBurny added the enhancement New feature or request label Mar 10, 2021
@BeroBurny BeroBurny self-assigned this Mar 10, 2021
@BeroBurny BeroBurny requested a review from a team as a code owner March 10, 2021 07:16
@BeroBurny BeroBurny changed the title Beroburny/docker images config from GitHub Docker images config from GitHub Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #532 (90283b1) into develop (79d6b09) will increase coverage by 0.13%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #532      +/-   ##
===========================================
+ Coverage    52.66%   52.79%   +0.13%     
===========================================
  Files           93       95       +2     
  Lines         1612     1644      +32     
  Branches       175      182       +7     
===========================================
+ Hits           849      868      +19     
- Misses         735      747      +12     
- Partials        28       29       +1     
Flag Coverage Δ
unit 52.79% <57.14%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/services/eth2/client/defaults.ts 40.00% <16.66%> (ø)
src/renderer/services/utils/githubReleases.ts 68.18% <68.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d6b09...90283b1. Read the comment docs.

docker.json Outdated Show resolved Hide resolved
@mpetrunic
Copy link
Member

mpetrunic commented Mar 10, 2021

Added clarification to issue:
#507 (comment)

@BeroBurny
Copy link
Collaborator Author

image

@BeroBurny BeroBurny requested a review from mpetrunic April 7, 2021 06:50
@mpetrunic
Copy link
Member

Can we put some badge next to recommended version in dropdown?

@BeroBurny
Copy link
Collaborator Author

Can we put some badge next to recommended version in dropdown?

something like this?
image

@BeroBurny BeroBurny requested a review from mpetrunic April 8, 2021 12:02
@BeroBurny BeroBurny merged commit 1b6ed34 into develop Apr 9, 2021
@BeroBurny BeroBurny deleted the beroburny/docker-images-config-from-github branch April 9, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants