Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings screem #548

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Settings screem #548

merged 6 commits into from
Mar 29, 2021

Conversation

BeroBurny
Copy link
Collaborator

Short description of work done

  • implement setting screen

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

  • implement setting screen
  • fix setting storing
  • refactor router context entery point

Example

image

image

Issues

Closes #538

@BeroBurny BeroBurny added the enhancement New feature or request label Mar 26, 2021
@BeroBurny BeroBurny self-assigned this Mar 26, 2021
@BeroBurny BeroBurny requested a review from a team as a code owner March 26, 2021 09:42
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #548 (069fbd0) into develop (ebcf234) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #548      +/-   ##
===========================================
+ Coverage    58.56%   58.61%   +0.04%     
===========================================
  Files           75       75              
  Lines         1255     1254       -1     
  Branches       150      150              
===========================================
  Hits           735      735              
+ Misses         493      492       -1     
  Partials        27       27              
Flag Coverage Δ
unit 58.61% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../renderer/services/db/api/repositories/settings.ts 60.00% <0.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcf234...069fbd0. Read the comment docs.

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for now but as we add more settings it will have to be bigger and grouped.

@BeroBurny BeroBurny merged commit c51b89b into develop Mar 29, 2021
@BeroBurny BeroBurny deleted the beroburny/settings branch March 29, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants