Track user count #552
Merged
Track user count #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #552 +/- ##
========================================
Coverage 58.59% 58.59%
========================================
Files 75 75
Lines 1256 1256
Branches 151 151
========================================
Hits 736 736
Misses 492 492
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mpetrunic
reviewed
Mar 31, 2021
| @@ -14,7 +15,12 @@ function* loadAccountSettings(): Generator<PutEffect | Promise<Settings | null>, | |||
| function* saveAccountSettings(action: {payload: ISettings}): Generator<PutEffect | Promise<void>> { | |||
| yield database.settings.set(DEFAULT_ACCOUNT, action.payload); | |||
|
|
|||
| if (action.payload.reporting !== undefined) yield put(setReporting(action.payload.reporting)); | |||
| if (action.payload.reporting !== undefined) { | |||
There was a problem hiding this comment.
Wouldn't this prevent changing reporting from true to false or reverse?
There was a problem hiding this comment.
ISettings all params are optional and this cover a case if is reporting not provided
mpetrunic
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of work done
PR Checklist
Changes
Example
Issues
Closes #540