Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon Node metrics #572

Merged
merged 6 commits into from
Jul 8, 2021
Merged

Beacon Node metrics #572

merged 6 commits into from
Jul 8, 2021

Conversation

BeroBurny
Copy link
Collaborator

Short description of work done

implement metrics tab on beacon node

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

  • implement beacon node metric tab
  • improve line chart

image

@BeroBurny BeroBurny added the enhancement New feature or request label Jul 8, 2021
@BeroBurny BeroBurny self-assigned this Jul 8, 2021
@BeroBurny BeroBurny requested a review from a team as a code owner July 8, 2021 06:10
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #572 (9b2e5db) into develop (e29c8dd) will decrease coverage by 0.11%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #572      +/-   ##
===========================================
- Coverage    48.79%   48.68%   -0.12%     
===========================================
  Files          117      117              
  Lines         2080     2085       +5     
  Branches       225      225              
===========================================
  Hits          1015     1015              
- Misses        1036     1041       +5     
  Partials        29       29              
Flag Coverage Δ
unit 48.68% <16.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vices/eth2/client/eth2ApiClient/cgEth2BeaconApi.ts 31.25% <ø> (ø)
...ervices/eth2/client/eth2ApiClient/cgEth2NodeApi.ts 8.33% <0.00%> (-2.78%) ⬇️
src/renderer/services/eth2/client/interface.ts 100.00% <ø> (ø)
...s/eth2/client/eth2ApiClient/cgEth2BeaconPoolApi.ts 18.75% <33.33%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29c8dd...9b2e5db. Read the comment docs.

@BeroBurny BeroBurny changed the base branch from master to develop July 8, 2021 06:10
@BeroBurny BeroBurny merged commit b12ea69 into develop Jul 8, 2021
@BeroBurny BeroBurny deleted the beroburny/bn-metrics branch July 8, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants