Prysm update #575
Merged
Prysm update #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeroBurny
requested review from
morrigan and
mpetrunic
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #575 +/- ##
===========================================
- Coverage 48.54% 48.17% -0.37%
===========================================
Files 117 117
Lines 2091 2115 +24
Branches 225 231 +6
===========================================
+ Hits 1015 1019 +4
- Misses 1047 1067 +20
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BeroBurny
added
enhancement
mpetrunic
reviewed
Aug 3, 2021
| try { | ||
| attestations = yield retry(2, 0, eth2API.validator.getAttesterDuties, epoch, [validatorState.index]); | ||
| attestationsFuture = yield call(eth2API.validator.getAttesterDuties, epoch + 1, [validatorState.index]); | ||
| } catch { |
There was a problem hiding this comment.
this try-catch block is in the case of some sort of error, we don't want to break application for failing to fetch some meta data for nonessential work for validating
There was a problem hiding this comment.
not sking you to break app, just log error message instead of ignoring it so we have some info when debugging
| propositions = yield call(eth2API.validator.getProposerDuties, epoch, [validatorId]); | ||
| propositionsFuture = yield call(eth2API.validator.getProposerDuties, epoch + 1, [validatorId]); | ||
| propositionsSuperFuture = yield call(eth2API.validator.getProposerDuties, epoch + 2, [validatorId]); | ||
| } catch { |
mpetrunic
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of work done
update prysm docker and client
PR Checklist