Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .exec() mutliple times on the same multi object, does not behave as README claims #923

Closed
tomsun opened this issue Nov 22, 2015 · 1 comment

Comments

@tomsun
Copy link

tomsun commented Nov 22, 2015

The README currently claims that re-running .exec() on a multi object that increments a key, is expected to increment the key once per .exec()
85b0f60#diff-04c6e90faac2675aa89e2176d2eec7d8R269
(I'm deducing that claim from the example output: // 101, 2, // 102, 3)

When trying to reproduce, my first exec() produces [ 101, 2 ] and the second produces [] (unless I add more operations to the multi object before running .exec() again).

Observed with v2.3.0


I don't mind the observed behavior; just want to make sure node_redis considers this the expected behavior - and README suggests otherwise.

@tomsun tomsun changed the title Using multi.exec() mutliple times does not behave as README claims Using .exec() mutliple times on the same multi object, does not behave as README claims Nov 22, 2015
@BridgeAR
Copy link
Contributor

Thanks for pointing this out! I was not aware, that this was supported. I removed the comment in the ready. Otherwise there would have been some downsides to re-enable this behavior and it should likely be a rare use case. If anyone feels otherwise, please feel free to comment to support re-enabling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants