EVAL function overwrite on index.js (:1068) caused lost of support to handle parameters as an array ( [ param1, param2, ... , paramN ], callback), since assumes all of them will be passed on extended format ( param1, param2, ... , paramN, callback ).
I added a simple validation to make it compatible. Also, updated example code to probe and show how this two formats works fine now.
EVAL: added missing support to handle parameters as an array
Looks good, could you add a test to tests.js? I added a little checklist so you can see how close this is to being merged.
Hey, while working on the test, I got some of them failing. After checking redis' site, I know what the problem is.
Basically,"Errors inside a transaction" at http://redis.io/topics/transactions states that version 2.6.5+ handles errors on a different way. Now, if you get an error, the whole transaction fails, as opposite to previous (and tested) behavior.
I already made some changes, but while doing that, I start to think that you might want to deal with this in a different way (I basically migrate all failing tests to make them 2.6.5+ compatible). Also, you might want to have this in a different pull request...
Let me know your decision and how can I help.
@dmoena I have a fix for making the tests 2.6.5+ compatible already, will be submitted as a PR soon. In the meantime feel free to comment out MULTI_1 and MULTI_2 tests in your workspace.
EVAL: parameters as an array test added to tests.js
I commented failing tests locally, just to add mine. Comments were removed before commit.
EVAL: allow parameters as an array. Close #368.
Signed-off-by: DTrejo <firstname.lastname@example.org>