Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests of MemoryHelper #354

Open
Vixenka opened this issue Nov 4, 2023 · 2 comments · May be fixed by #360
Open

Tests of MemoryHelper #354

Vixenka opened this issue Nov 4, 2023 · 2 comments · May be fixed by #360
Labels
good first issue Good for newcomers priority: low Low priority technical debt It affects the difficulties of future development

Comments

@Vixenka
Copy link
Member

Vixenka commented Nov 4, 2023

NoiseEngine/NoiseEngine/Common/MemoryHelper.cs

Line 15 in 98d8bfa

public static nuint AlignmentOf<T>() where T : unmanaged {

NoiseEngine/NoiseEngine/Common/MemoryHelper.cs

Line 25 in 98d8bfa

public static bool IsDangling<T>(nuint address) where T : unmanaged {

@Vixenka Vixenka added good first issue Good for newcomers priority: low Low priority technical debt It affects the difficulties of future development labels Nov 4, 2023
@Vixenka Vixenka modified the milestone: 0.1.0 Nov 4, 2023
@aaroniz-bgu aaroniz-bgu linked a pull request Nov 7, 2023 that will close this issue
Draft
@kkard2
Copy link
Contributor

kkard2 commented Nov 8, 2023

isn't this fixed by #361?

@Vixenka
Copy link
Member Author

Vixenka commented Nov 8, 2023

@kkard2 good point, but it was fixed partialy, because only AligmentOf have their tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority: low Low priority technical debt It affects the difficulties of future development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a test for NoiseEngine.Common.MemoryHelper aaroniz-bgu/NoiseEngine
2 participants
@Vixenka @kkard2