Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rion doesn't work in current league patch #4

Closed
GuiSaiUwU opened this issue Oct 10, 2022 · 7 comments
Closed

Rion doesn't work in current league patch #4

GuiSaiUwU opened this issue Oct 10, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@GuiSaiUwU
Copy link

GuiSaiUwU commented Oct 10, 2022

when you use Rion to edit text, and save back to use, some text will broken even if you didn't touched them.
example: I edited twitch E name, but everything in settings menu got broken text

@Wenveo
Copy link
Owner

Wenveo commented Oct 12, 2022

Could you please specifically describe what you have changed or upload a screenshot?
I tested it on both NA and CN servers and did not find broken text.

image
image
image
image

@Wenveo Wenveo added the question Further information is requested label Oct 12, 2022
@GuiSaiUwU
Copy link
Author

Contaminar
test rion
Note: I used cntrl F to change every ";Contaminar" to ";Test Rion", don't know if that would influence that much
Screen413
Screen414
Screen415
Screen416
Screen417
Screen418

@GuiSaiUwU
Copy link
Author

GuiSaiUwU commented Oct 16, 2022

I had a test before with Lee Sin and when I tried to look at the R tooltip just crashed league, one friend had the same issue with broken text, while editing global.es_ES, don't know if that is a thing related to latin languages [mine is pt_BR], but Rion wasn't having any issues before
Screen411

@Wenveo Wenveo added bug Something isn't working and removed question Further information is requested labels Oct 16, 2022
@Wenveo
Copy link
Owner

Wenveo commented Oct 16, 2022

When converting from json to rst, I found cases where the byte with the ending was not equal to 0.
~0Y1 ROUNH8XF$BS)IM))(9

But if I open an RST file and write it out, it doesn't happen that the ending byte is not equal to zero.
74Q21YAZR%97DW7U)LMJSR6

@Wenveo
Copy link
Owner

Wenveo commented Oct 16, 2022

This is the simplest fix, and it works just fine.
image

The content remains consistent after multiple conversions through the converter.
image

Json is same.
image

and rst
image

@Wenveo Wenveo transferred this issue from Wenveo/rion Oct 16, 2022
Wenveo added a commit that referenced this issue Oct 16, 2022
@Wenveo
Copy link
Owner

Wenveo commented Oct 16, 2022

@GuiSaiUwU The latest version of rion has fixed this bug.
https://github.com/Noisrev/rion/releases/tag/v0.1.2.23974

If you have no other questions, this issue will be closed in a week.

@GuiSaiUwU
Copy link
Author

Ok ok if I have any issues again I open another thread <3

@Wenveo Wenveo closed this as completed Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants