Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove freezed dependency #9

Closed
stargazing-dino opened this issue Jan 27, 2021 · 1 comment
Closed

Remove freezed dependency #9

stargazing-dino opened this issue Jan 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@stargazing-dino
Copy link
Owner

As much as I love and use freezed in my own projects, I don't think this is a necessary requirement for such a simple library. I can't really think of a better way to handle the sealed union nature of the AppState though and would love some suggestions.

This only seems like an issue for me now because freezed requires freezed_annotations and that depends on json_annotations which, thanks to nnbd, a lot of other libraries are not quite up to speed on requiring their v4.0.0 version. As a result, this will break dep resolution for some users.

Another option would to be to publish a stable 2.0.0 version that isn't nnbd and uses the older version. People could still depend on this package then without breaking things.

@stargazing-dino stargazing-dino added the enhancement New feature or request label Jan 27, 2021
@stargazing-dino
Copy link
Owner Author

Nah, I'm going to close this. Feel free to comment to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant