Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internally handle failed batch requests due to type changes #239

Closed
Tracked by #303
Wodann opened this issue Nov 29, 2023 · 1 comment
Closed
Tracked by #303

Internally handle failed batch requests due to type changes #239

Wodann opened this issue Nov 29, 2023 · 1 comment

Comments

@Wodann
Copy link
Member

Wodann commented Nov 29, 2023

When the cached type doesn't match the expected type for a batch request item, we currently delete the cache item and fail the call. Instead, we should delete the cache item and then proceed to fetch the request from the remote.

There are two ways to go about this:

  1. Have the generic batch request method return concrete types instead of serde_json::Value. This would be the preferable solution, but heterogenous lists are difficult to express with the Rust type system.
  2. Handle it in methods that use the generic batch request method to make concrete batch calls.

Related #238

Definition of done

When the cached type doesn't match the expected type for a batch request item, the faulty cache item is deleted and the request is fetched the request from the remote.

@fvictorio
Copy link
Member

No longer relevant.

@fvictorio fvictorio closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants