Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for block timestamps #286

Closed
Tracked by #303
Wodann opened this issue Feb 8, 2024 · 0 comments · Fixed by #395
Closed
Tracked by #303

Add test for block timestamps #286

Wodann opened this issue Feb 8, 2024 · 0 comments · Fixed by #395
Assignees
Milestone

Comments

@Wodann
Copy link
Member

Wodann commented Feb 8, 2024

Hardhat used to have tests to validate the timestamp logic in HardhatNode. These tests used SinonFakeTimers to manually manipulate the observed system clock.

This can not be achieved in the same way but instead requires a refactor of EDR to support an interface for determining the block's timestamp. As such, these tests were not ported when ethereumjs was replaced.

Definition of Done

  • Refactor EDR to receive a trait (object) for determining the block's timestamp
  • Add tests based on Hardhat tests that validate block timestamp calculation
@Wodann Wodann mentioned this issue Feb 26, 2024
29 tasks
@Wodann Wodann self-assigned this Apr 4, 2024
@Wodann Wodann added this to the EDR v0.3.6 milestone Apr 16, 2024
@Wodann Wodann linked a pull request Apr 24, 2024 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
1 participant