Validation on duplicate module ids in visualization

[kanej]

@maguroid reported an issue where visualization failed when running against this module:

https://github.com/maguroid/hardhat-ignition-demo/blob/factory-pattern/ignition/modules/Vault.ts

It appears to reduce down to:

import { buildModule } from "@nomicfoundation/hardhat-ignition/modules";
import VaultFactory from "./VaultFactory";

import hre from "hardhat";

const hex3 = hre.ethers.toBeHex(3, 20);

const VaultFactory = buildModule("Vault", (m) => {
  const vaultFactory = m.contract("VaultFactory");

  return {
    vaultFactory,
  };
});

const UniswapV3Swapper = buildModule("UniswapV3Swapper2", (m) => {
  const uniswapV3Swapper = m.contract("UniswapV3Swapper", [hex3]);

  return {
    uniswapV3Swapper,
  };
});

// * NOTES: deployment with factory currently not working as expected.
// *        deployed address not stored in json file, and visualization throws error
export default buildModule("Vault", (m) => {
  const { vaultFactory } = m.useModule(VaultFactory);
  const { uniswapV3Swapper } = m.useModule(UniswapV3Swapper);

  return {
    vaultFactory,
    uniswapV3Swapper,
  };
});

I suspect this is the reuse of the module id. Where the top level module has id Vault but so does one of its submodules.

We should add buildModule validation to cover this case.