Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Go To Definition does not work or is not fully resolved #553

Open
DrakeEvans opened this issue Apr 12, 2024 · 4 comments
Open

Comments

@DrakeEvans
Copy link

Feature: Go To Definition should support function definitions as well as fully resolve Definitions

Current Situation: Function definitions not supported, For supported symbols Go To Definition only goes to the nearest declaration not to the implementation

Current.mp4

Proposed: Function definitions supported, Go To Definition fully resolves to implementation not nearest declaration

OptimalOutcome.mp4
@DrakeEvans
Copy link
Author

The OptimalOutcome.mp4 is generated from using the Tools For Solidity extension

@kanej
Copy link
Member

kanej commented Apr 15, 2024

Hey @DrakeEvans, thanks for the reproduction videos they are always valued.
Can you point me to to the repo you where using if its open source?

@DrakeEvans
Copy link
Author

@kanej Yes you can see it at https://github.com/agora-finance/agora-dollar-evm-tests/blob/master/src/test/erc20-privilaged/TestMinting.t.sol

You will need to run forge install and npm i to make it work

@DrakeEvans
Copy link
Author

DrakeEvans commented Apr 18, 2024

Will need to run npm i inside of one submodule as well cd lib/agora-dollar-evm/ && npm i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants