Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardhat-ethers doesn't reset the provider when a snapshot is reverted #1247

Closed
fvictorio opened this issue Feb 13, 2021 · 4 comments
Closed

hardhat-ethers doesn't reset the provider when a snapshot is reverted #1247

fvictorio opened this issue Feb 13, 2021 · 4 comments
Labels
type:bug Something isn't working

Comments

@fvictorio
Copy link
Member

We reset the provider when hardhat_reset is called, but not when evm_revert is called.

Related issue: ethers-io/ethers.js#1155
@fvictorio fvictorio added package:hardhat-core type:bug Something isn't working labels Feb 13, 2021
@fvictorio fvictorio mentioned this issue Mar 17, 2021
Closed
@nionis nionis mentioned this issue Apr 7, 2021
Merged
@fvictorio fvictorio mentioned this issue May 14, 2021
Merged
@fvictorio fvictorio mentioned this issue Oct 18, 2021
Closed
@scnale
Copy link
Contributor

scnale commented Nov 20, 2021

Hey! As far as I can see, this should be fixed in the current source of hardhat-ethers but there was no release of the plugin itself since the fix. Is there something blocking it?

@pilagod
Copy link

pilagod commented Nov 22, 2021

Same here, I just ran into this problem.

@fvictorio Is there any release plan to include this fix? Thanks.

@fvictorio
Copy link
Member Author

Oops, you are 100% right. This will be included in the next release.

@fvictorio fvictorio mentioned this issue Nov 25, 2021
Merged
@github-actions github-actions bot mentioned this issue Nov 26, 2021
Merged
@fvictorio
Copy link
Member Author

Fixed in @nomiclabs/hardhat-ethers@2.0.3.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fvictorio @pilagod @scnale