Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Non-FOSS in F-Droid build - io.objectbox:objectbox-gradle-plugin #70

Open
licaon-kter opened this issue Sep 26, 2022 · 13 comments
Open

Comments

@licaon-kter
Copy link

licaon-kter commented Sep 26, 2022

ref: https://github.com/Nonononoki/Hendroid/blob/v1.16.9/build.gradle#L12 (since 516ff98 )

Ref: objectbox/objectbox-java#560

Ref: https://gitlab.com/fdroid/fdroidserver/-/merge_requests/1150

@licaon-kter
Copy link
Author

@LeoColman
Copy link

@Nonononoki
If you're looking for an alternative, I've considered

  • Realm
  • Room
  • LitePal
  • SQLDroid + KTorm

And ended up with SQLDelight.
I found it easy to use, it's very well maintained and seemed to me the closes solution with the "easier" migration.
I decided to bump it to a new major version instead of trying anything to migrate the previous database. My app already had an Export/Import option.

All commits related to this can be found in LeoColman/Petals@b00f1e4...3.0.2

I tried to keep the history as clean and clear as possible to facilitate migration for others.

@Nonononoki
Copy link
Owner

@LeoColman I've decided to just include the library source directly.

@Nonononoki
Copy link
Owner

Nonononoki commented Sep 30, 2022

@licaon-kter Any reason why my app was removed completely from F-droid? The page only shows a 404: https://f-droid.org/de/packages/org.nonononoki.hendroid/

@LeoColman
Copy link

LeoColman commented Sep 30, 2022

@Nonononoki
I believe it's because you've used Objectbox since build one.
When you release a new build and change the Update Mode
https://gitlab.com/fdroid/fdroiddata/-/commit/a8d558ff62e6411547466fc3a7b57c22b7c56aee#7f105fae0f21efd5cbbe93cf0918e0248eac7380_696_703

It will resume

In summary, only the builds with the tainted software were removed. In Hendroid's case it was all of them 🙈

@Nonononoki
Copy link
Owner

@LeoColman Not the first time I merged upstream changes with non-FOSS plugins (#24), but this is the first time app was completely removed. Usually F-droid just keep the page open with the older version.

@LeoColman
Copy link

LeoColman commented Sep 30, 2022

That's the case here, however there isn't any older version for F-Droid to display, as all versions have the non-foss plugin

@licaon-kter
Copy link
Author

@Nonononoki yes. It's unfortunate :(

How will you include the source exactly?

@Nonononoki
Copy link
Owner

@licaon-kter Already did with this commit 7336782
The plugin may be non-FOSS but the code is still Apache 2.0

@Nonononoki
Copy link
Owner

Ok, didn't work. Building works but will get errors :(

@LeoColman
Copy link

What are the errors?
Something binary related?

@Nonononoki
Copy link
Owner

@LeoColman Yeah, it needs a binary library file. UnsatisfiedLinkError

@LeoColman
Copy link

That's what the plug-in downloads and adds to your app. It is proprietary as well 😔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants