Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigurationLoader and CollectorConfigLoader interaction #19

Open
danizen opened this issue Feb 2, 2018 · 0 comments
Open

ConfigurationLoader and CollectorConfigLoader interaction #19

danizen opened this issue Feb 2, 2018 · 0 comments

Comments

@danizen
Copy link
Contributor

danizen commented Feb 2, 2018

Current Behavior

A Java-level user can write their own alternative to ConfigurationLoader and CollectorConfigLoader, and achieve the ability to inject properties from memory into the Collector, but it is a bit out of the way to do this. The best way to extend it with current structure would be to construct a Properties object dynamically, save it to disk, and then pass that temporary file to the loader.

Desired Behavior

ConfigurationLoader in commons-lang should be restructured so that an CollectorConfigLoader can either provide a commons-lang Properties object or a File when loading configuration, or a File.

Motivation

A little bit round-about to save to a file first. Refactoring would be good, but it is a minor request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants