#373 newProject accounts for team #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezamj03
requested review from
RChandler234,
jamescd18,
anthonybernardi and
callmejim1226
anthonybernardi
requested changes
Dec 28, 2022
anthonybernardi
requested changes
Dec 30, 2022
anthonybernardi
requested changes
Jan 4, 2023
nezamj03
force-pushed
the
#373-New-Proj
branch
from
211b017
to
db8e6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made a check to see if the request body includes teamId. If it does not include teamId, a project is similarly created without any teamId, but if it is provided, it verifies for a valid teamId and if it is not, it will send a 404. if it is, it will create the project with the teamId.
Notes
n/a
Test Cases
passed all tests
To Do
require a teamId in order to not check for an unprovided one.. transition to requiring teamIds
Closes #373