-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnetcore support #7
Comments
Has dotnetcore stopped being a moving target yet? ;) I'm happy for anyone to have a go at it but I'm not personally going to spend any meaningful effort on anything dotnetcore-related until NUnit, ReSharper and TeamCity all support it nicely. |
I think there are a few parts to it.
I'd be happy to do the code changes for 1 and 2 - it should be pretty straight forward and I've done a fair bit of work in that space recently. But I'm not sure about the impact on the build/publish pipeline so would need a bit of advice on that. How do you publish to to Nuget at the moment? |
I've had a bit more of a look into this. I can see a way to do it - but the forthcoming move away from xproj and back to csproj may make it worthwhile to leave it for the moment. |
@flytzen That has happened now. Did you find a way to make it work with Core? |
I didn't, but I was just thinking the other day that I should give it a go, so happy to do that. |
@flytzen I still haven't made the move to VS2017... Guess it's time. 😆 |
Just FYI; work has started. Looking quite straight forward so far on the general porting. Only real question is about how you currently pack? I assume a manual Nuget Pack with the version numbers on the command line? If you use an automatic service, please let me know which. |
Update (@grokky1) : Everything is now running on .Net core and there is an ASP.Net Core sample app. Current work is here: https://github.com/flytzen/NotDeadYet/tree/DotNetCore. Main outstanding task is to remove the nuspec files and set up a simple package generation script. There is one small item that stops it being completely done; NUnit doesn't currently work with Core and VS2017. The simplest short-term fix would be to convert the unit tests to XUnit, but not sure how you feel about that, @uglybugger? That should allow the tests to run with both the frameworks as well. Of course, MS are rather pissing on this parade with this little gem: https://github.com/aspnet/HealthChecks |
Haven't tried in VS2017. But NUnit definitely works with .NET Core. |
@grokky1 Yes, I'm talking about this issue with the runner and the new csproj format: nunit/dotnet-test-nunit#108. Sorry for not being clear. |
Wow what a mess... It's not their fault though. Glad I'm still on vs2015 then 😆 They usually get things right though, so it's only a matter of time before they get it working. |
Is there any activity on this ? .NEt core is now 2.0 with 2.1 around the corner. Is this project likely to be maintained going forward ? |
@graemechristie It appears to be dead, sadly. |
@Jaxelr @uglybugger Ah, cool stuff :) |
Any thoughts on whether it'd be worth adding dotnetcore support?
It's sort-of separate from adding aspnetcore support.
The text was updated successfully, but these errors were encountered: