Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested templates mess up {{GA nominee|status= detection #209

Open
NovemLinguae opened this issue Mar 29, 2024 · 1 comment
Open

nested templates mess up {{GA nominee|status= detection #209

NovemLinguae opened this issue Mar 29, 2024 · 1 comment
Labels
GANReviewTool

Comments

@NovemLinguae
Copy link
Owner

NovemLinguae commented Mar 29, 2024 •
edited
Loading

Reported by Mike Christie at https://en.wikipedia.org/wiki/User_talk:Novem_Linguae/Scripts/GANReviewTool#Possible_bug_in_the_GANReviewTool

Diff showing error. Notice that status is added for a 2nd time, instead of updating the existing status: https://en.wikipedia.org/w/index.php?title=Talk:Frank_J._Wood_Bridge&diff=prev&oldid=1212095306

image
@NovemLinguae
Copy link
Owner Author

NovemLinguae commented Mar 29, 2024 •
edited
Loading

This is a nested template bug. The proper fix would involve switching from my custom regexes to the Parsoid API so I can parse wikicode properly without reinventing the wheel.

Related #138 Use Parsoid for template parameter modification?

@NovemLinguae NovemLinguae mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GANReviewTool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NovemLinguae