Add linked option/lockstep #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noviny
reviewed
May 7, 2019
| @@ -0,0 +1,88 @@ | |||
| /* | |||
| Hey, welcome to the changeset config! This file has been generated | |||
There was a problem hiding this comment.
It sounds like you didn't want this config file from the replacement readme text?
There was a problem hiding this comment.
Or was that from a different fixture?
There was a problem hiding this comment.
Whoops, the readme text is wrong, I just copied this fixture from another one and updated the part of the config I needed to.
Noviny
reviewed
May 7, 2019
| @@ -0,0 +1,88 @@ | |||
| /* | |||
| Hey, welcome to the changeset config! This file has been generated | |||
There was a problem hiding this comment.
Or was that from a different fixture?
| for (let linkedPackages of allLinkedPackages) { | ||
| let highestVersion; | ||
| for (let linkedPackage of linkedPackages) { | ||
| let version = currentVersions.get(linkedPackage); |
There was a problem hiding this comment.
We can use 'let' again in our code. I could cry. In sadness. About having obeyed bad lint rules.
There was a problem hiding this comment.
We need a support group for people who have been affected by prefer-const eslint rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
I think we ended up deciding on calling the option
linked, not sure if I'm remembering correctly though.The behavior here is that nothing changes for adding changesets. You still write changesets for individual packages. During bumping, for each set of linked packages, it'll find the highest bump type and the highest current version of all the packages in the set and and set the new version for all the packages in the set that are being released to highest current version + highest bump type.
An example
I have three packages,
pkg-a,pkg-bandpkg-c.pkg-aandpkg-bare linked butpkg-cis not so the config looks like this.pkg-ais at1.0.0pkg-bis at1.0.0pkg-cis at1.0.0I have a changeset with a patch for
pkg-a, minor forpkg-band major forpkg-cand I do a release, the resulting versions will be:pkg-ais at1.1.0pkg-bis at1.1.0pkg-cis at2.0.0I now have another changeset with a minor for
pkg-aand I do a release, the resulting versions will be:pkg-ais at1.2.0pkg-bis at1.1.0pkg-cis at2.0.0I now have another changeset with a minor for
pkg-band I do a release, the resulting versions will be:pkg-ais at1.2.0pkg-bis at1.3.0pkg-cis at2.0.0I now have another changeset with patches for all three packages and I do a release, the resulting versions will be:
pkg-ais at1.3.1pkg-bis at1.3.1pkg-cis at2.0.1I'm pretty sure this example shows all the cases for lockstep and it's the behavior I'm pretty sure I want for emotion.