Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lazydata = FALSE and removing raster from imports #25

Closed
Nowosad opened this issue Nov 23, 2021 · 11 comments
Closed

Consider lazydata = FALSE and removing raster from imports #25

Nowosad opened this issue Nov 23, 2021 · 11 comments

Comments

@Nowosad
Copy link
Owner

Nowosad commented Nov 23, 2021

No description provided.

@Nowosad
Copy link
Owner Author

Nowosad commented Feb 1, 2022

@Robinlovelace @jannes-m What do you think about the idea of disabling lazydata and removing raster from imports in spDataLarge?

@Robinlovelace
Copy link
Collaborator

Good plan, 👍 needed by end of 2023, right?

@Nowosad
Copy link
Owner Author

Nowosad commented Feb 2, 2022

At latest. I think we can do that when (a) we avoid using this feature (lazydata from spDataLarge) in geocompr2, and (b) geocompr2 is published.

@jannes-m
Copy link
Contributor

jannes-m commented Feb 15, 2022

Should I convert the raster files in the landslides, the mongon and the ep_eco datasets from raster to terra? Hopefully, the corresponding code adjustments will be not too labour intensive...

@Nowosad
Copy link
Owner Author

Nowosad commented Feb 15, 2022

@jannes-m Correct me if I am wrong, but you cannot save terra objects directly to rda (you would need to use wrap to save it, and rast to read it). My current approach is to use .tif files saved in inst/raster and documented in the R folder (https://github.com/Nowosad/spDataLarge/blob/master/R/rasters.R).

@jannes-m
Copy link
Contributor

Ah ok, no, I didn't know that one can not save terra objects as rds files. I didn't know either that you have already put most of the raster files into a raster folder. So thanks for letting me know. Some terrain attributes of the raster bricks ta and ep are still missing in the raster folder (catchment area, catchment slope, etc.) . Should we add them to the raster folder as multi-layer files or do you prefer to keep ta and ep?

@Nowosad
Copy link
Owner Author

Nowosad commented Feb 15, 2022

I think we should use terra objects (or raster files) consistently through the book (and avoid raster objects). If you plan to use ta and ep in the book, then yes -- save them in the raster folder and add/update the documentation. Let me know if you need any help. J

@jannes-m
Copy link
Contributor

Ok, then I will update these files and use terra files throughout the book.

@Nowosad
Copy link
Owner Author

Nowosad commented Jun 5, 2022

This is not a priority now, but I made a version of the package that does not depend on {raster} -- #31. We can marge this PR whenever we want...

@Nowosad
Copy link
Owner Author

Nowosad commented Oct 4, 2023

Merge completed.

@Nowosad Nowosad closed this as completed Oct 4, 2023
@Robinlovelace
Copy link
Collaborator

Great work Jakub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants