Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.1 #17

Merged
merged 7 commits into from Mar 24, 2017
Merged

Swift 3.1 #17

merged 7 commits into from Mar 24, 2017

Conversation

lichtblau
Copy link
Contributor

Port to Swift 3.1 (tested with the swift-3.1-DEVELOPMENT-SNAPSHOT-2017-03-19-a-ubuntu16.10 tarball).

In this branch:

  • Fixing the build error is a whitespace change... This is the one and only commit that actually matters.
  • Various super important warnings being addressed. Hope this doesn't break anything. Tests pass.
  • Unrelated semicolon change after touching that file...

Not in this branch:

  • Something about pointer arithmetic remains. Fixable, but I've got more questions than answers about that code.
  • readdir_r is apparently pointless and should be replaced with readdir
  • Warnings in tests could also be addressed.
  • Need to update the dgram copy&paste files similarly.

There are several ways to quiet down swift on the string interpolation of optionals. I've opted for the "as Optional" instead of ".debugDescription" for no big reason. Both seem roughly equally ugly.

@helje5
Copy link
Member

helje5 commented Mar 22, 2017

OK, I'm going to check it out tomorrow. I assume this should not affect Swift 3.0.2 builds, right? (I see Travis is passing, but still).

@helje5
Copy link
Member

helje5 commented Mar 22, 2017

readdir_r is apparently pointless

The web says it is 'harmful' ;->

The macOS man page of readdir doesn't say whether it is thread safe or not (the Linux one is for our purposes).
While we are only on one thread right now, I think we should keep the doors open to run on multiple accept queues in one process.

@helje5 helje5 merged commit fcfa029 into NozeIO:develop Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants