Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NsCDE freezes when deiconifying an icon on the desktop #113

Closed
simply1233 opened this issue Aug 12, 2022 · 16 comments
Closed

NsCDE freezes when deiconifying an icon on the desktop #113

simply1233 opened this issue Aug 12, 2022 · 16 comments

Comments

@simply1233
Copy link

Whenever I deiconify an icon on the desktop, NsCDE completely locks up forcing me to reboot or kill Xorg.

@jhgalino
Copy link

I am experiencing the same issue.

@wallacewinfrey
Copy link

wallacewinfrey commented Aug 23, 2022

I am also experiencing this issue. For myself (running Manjaro), it seems like it was introduced when the nscde-git AUR package upgraded from 2.0.r18.c14e6a05-1 (c14e6a0) to 2.2.r2.g28a4a4a1-1 (28a4a4a) - so it was definitely one of the ~72 commits between those SHAs....

@simply1233
Copy link
Author

I believe I found a way to fix it, instead of using the default fvwm, set it to fvwm3-git.

@marcdw1289
Copy link

Had this issue for some time on Garuda also.
I restarted fresh but don't remember if I used fvwm3 or the git version but the issue is still there.
If I'm working on anything important I have to remember not to iconify anything.
Noticed that any icons on the desktop will lose their image at time of lockup, producing gray-filled icons.

The keyboard still works so I can drop to a terminal and kill fvwm. That kills the whole desktop and returns me back to the display manager.

@b65sol
Copy link

b65sol commented Sep 6, 2022

@wallacewinfrey I'm actually able to reproduce this problem on arch all the way back to a1d503c (I haven't checked further) which leads me to suspect its an arch-specific config responsible. Oddly, deiconifying with right-click works.

I don't know enough about FVWM (or arch repo management for that matter) to dig further. :(

I do have a ISO + qemu reproduction though.

[Edit: Worth noting that X itself isn't unresponsive, just FVWM. xscreensaver ran in my qemu window a bit after I posted this.]

@NsCDE
Copy link
Owner

NsCDE commented Sep 6, 2022

Strange.

I will update my Arch VM and try this.

BTW, have you tried to type Ctrl+Alt+Escape (couple of times) maybe fvwm is stuck in some function.

I'm testing NsCDE on various popular distros and BSD's and never saw such freaky bug. As said, I will try this on Arch VM this days. Small change, but maybe fvwm is miscompiled or something like that, because Menu popup which appears on 1st mouse button click on the icon should is just a menu popup which are plenty of them in NsCDE, and shouldnt produce such dramatic results.

@b65sol
Copy link

b65sol commented Sep 6, 2022

ctrl-alt-escape does not do anything unfortunately. It is odd behavior. I was able to work around it by using fvwm3-git for my archiso environment.

Video (nscde-git, fvwm 2.6.8 from arch repository):

nscde-repro-video.mp4

If needed, I could upload the full archiso config + custom repo I use to reproduce this.

For the ISO used in the video all I have installed is this (plus their dependencies):

packages.txt

@NsCDE
Copy link
Owner

NsCDE commented Sep 7, 2022

@b65sol

Thanks for this very helpful video!

Amazing bug, probably something with default FVWM, maybe miscompiled. I will make tests this days and if it is FVWM bug forward to my "upstream".

@NsCDE
Copy link
Owner

NsCDE commented Sep 17, 2022

Hi @b65sol @simply1233 @jhgalino @wallacewinfrey @marcdw1289

I was not able to reproduce this with non-updated Arch with kernel 5.16.X, but after update to the latest 5.19.9 problem appears. I was able to reproduce this. Fvwm must be killed with "-9" to unlock, kill X and get login screen.

I see that Fvwm 2 package was NOT updated, and it is the same as before.

Problem is either with some X libraries, X server, or even with kernel in all this combinations. NsCDE is not for sure, fvwm too, but something from underlaying things mentioned above.

EDIT: unfortunately, Arch doesn't leave 1-2 old kernels for booting manually from grub, so I cannot compare without kernel downgrade, and I don't know how to do this on Arch.

@NsCDE
Copy link
Owner

NsCDE commented Sep 19, 2022

For all affected:

  • Open /usr/share/NsCDE/fvwm/Functions.fvwmconf
  • Near the line 1853 there is a function f_IconOpsBasicCtx
  • At the end of second line of the function, you will find "Iconify Off"
  • Prepend it with Schedule 250, like this:

Schedule 250 Iconify Off

  • Open terminal.
  • Execute nscde_fvwmclnt 'f_ReadCfg Functions'

This temporary workaround works for me. This is not due to NsCDE nor fvwm, but some fix in X libraries which are breaking some window managers. Main author of fvwm3 is not sure why recent master branch of fvwm3 is immune to this, but we will find step by step where the code changed in a way to not hit this. Even then, if there are multiple icons, when deiconifying one icon, the other one may be left empty without drawing and label. Mouseover will refresh it, not a stopper, just a bit annying for now.

@ThomasAdam
Copy link

See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016363

It's via X11's change here: https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/157

Some work has already been done in FVWM to help with this (5c17c83df4605d2d97999740cf180af983298896) -- which is probably why some users are saying using fvwm3-git helps.

@b65sol
Copy link

b65sol commented Sep 23, 2022

@NsCDE Thanks much! That did correct it within my repro environment.

For others affected by this: If a double-click to deiconify also freezes FVWM, add the same schedule before Iconify False in f_IconOps

@cvjb
Copy link

cvjb commented Sep 30, 2022

@NsCDE @b65sol Thanks allot. Both schedule settings worked for me with NsCDE 2.2-1.2 and Opensuse Tumbleweed.

@NsCDE
Copy link
Owner

NsCDE commented Oct 1, 2022

Remember guys, this is a temporary workaround. It will go off when either Xorg makes better patch, or fvwm adopts to this one. For now, I just want for things to work, so there are this silly timeouts. :-)

@ghost
Copy link

ghost commented Dec 8, 2022

this bug is present on fedora 37.

I'm using the package in fedora's repos, which is still on 2.1. I've also manually added the following:
57803af
aeb43b9
944f907

There appears to be one issue still. When I have say my text editor iconified, and I open a text document in my file browser, it will then deiconify the text editor and open it in a new tab. This results in a crash.

Also for those affected, what I do if I was working on something important is to switch to a tty and do the following:
sudo kill -9 $(pidof fvwm)
DISPLAY=:0 kwin_x11

It will still be buggy (the titlebars are invisble), but it will be functional enough to complete what you were doing.

@StefanSchippers
Copy link

Some time has passed, so don't know if my comment may help.
I have the exact same issue on Debian happening after a libX11 update from 1.8.3-something to 1.8.4-something.
I have filed bug reports to debian, devuan and upstream:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032984
https://bugs.devuan.org/cgi/bugreport.cgi?bug=751
https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/186

For the time being reverting my libX11 and libX11-xcb1 to 1.8.3 fixes all my issues.
I have put these packages on hold in my system to prevent upgrades until some fix is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants