Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Recline to fix "Negative longitude numbers are parsed incorrectly" #138

Closed
pmackay opened this issue May 23, 2014 · 6 comments
Closed

Comments

@pmackay
Copy link

pmackay commented May 23, 2014

When importing a dataset for Lambeth, it was showing as points on the map way to the East. Recline.js was removing the "-" sign from the front of the longitude value, hence flipping the points across the zero dateline :)
Changing line 2463 from:
var dms = coord.split(/[^\.\d\w]+/);
to
var dms = coord.split(/[^-?\.\d\w]+/);
seemed to fix it.

@acouch
Copy link
Contributor

acouch commented May 23, 2014

Thanks, is this something that could be fixed upstream with Recline?

@pmackay
Copy link
Author

pmackay commented May 23, 2014

Yes, what's the best way to do that? Just raise the issue on Recline?

When do you pull updates to Recline?

On 23 May 2014, at 15:49, Aaron Couch notifications@github.com wrote:

Thanks, is this something that could be fixed upstream with Recline?


Reply to this email directly or view it on GitHub.

@pmackay
Copy link
Author

pmackay commented Jun 1, 2014

What version of recline are you currently using? How often do you update?

@pmackay
Copy link
Author

pmackay commented Jun 1, 2014

Raised on recline here: datopian/datahub#429

@acouch acouch changed the title Negative longitude numbers are parsed incorrectly Update Recline to fix "Negative longitude numbers are parsed incorrectly" Jun 2, 2014
@acouch
Copy link
Contributor

acouch commented Jun 2, 2014

Fantastic! I've updated the ticket title. Now we need to update Recline to see the fix. We just need to update the commit # we are pegged to: https://github.com/nuams/dkan/blob/7.x-1.x/dkan_dataset_dev.make#L185 . Can you test it locally and do a PR?

acouch added a commit to GetDKAN/recline that referenced this issue Jun 6, 2014
sheldonrampton added a commit to GetDKAN/recline that referenced this issue Jun 6, 2014
Issue GetDKAN/dkan#138 update recline to fix negative lat/lon
@acouch
Copy link
Contributor

acouch commented Jun 6, 2014

I've created a pull request.

teosibileau added a commit to GetDKAN/dkan_dataset that referenced this issue Jun 24, 2014
Issue GetDKAN/dkan#138: Moving dkan_dataset.make modifications to dkan_...
acouch referenced this issue Jul 1, 2014
+ changing git urls with https urls in order to travis to not fail during make
@acouch acouch closed this as completed Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants