Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing .NET 6 correctly on the dependencies #1367

Closed
timheuer opened this issue Sep 10, 2021 · 2 comments · Fixed by #1368
Closed

Not showing .NET 6 correctly on the dependencies #1367

timheuer opened this issue Sep 10, 2021 · 2 comments · Fixed by #1368

Comments

@timheuer
Copy link

The display for net6 is not consistent with others.

Type (choose one):

  • Bug

NPE version: NuGet Package Explorer - Store - X64 - (5.10.43+ce9a70d0c5)

OS version: Windows 10

Installed from: Microsoft Store

In case of a BUG:
image

@campersau
Copy link
Collaborator

NuGet.Client returns a different ToString value for >= net5.0 that's why it is also different there.
https://github.com/NuGet/NuGet.Client/blob/f4ae349ec18d1ac5d5e7d1b0ed753e1300e9e157/src/NuGet.Core/NuGet.Frameworks/NuGetFramework.cs#L458-L463

But in other places we explicitly show the DotNetFrameworkName instead, so maybe we should do the same here as well.

return $" ({frameworkName.DotNetFrameworkName})";

var fxs = string.Join("; ", far.SupportedFrameworks.Select(fn => fn.DotNetFrameworkName));

return frameworkNames == null ? string.Empty : string.Join("; ", frameworkNames.Select(fn => fn.DotNetFrameworkName));

Example with fix:
image

@svick
Copy link
Contributor

svick commented Sep 10, 2021

Since .NETCoreApp,Version=v5.0 is correct, but also cofusing, wouldn't it be better to show a "friendly" framework name, like ".NET 5.0"? I guess it depends on the target audience of NPE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants