Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: proguard fails when trying to use minifyEnable: true #72

Open
fabriziomoscon opened this issue May 8, 2017 · 1 comment
Open

Comments

@fabriziomoscon
Copy link

I am not an expert with proguard but I think the following warning could be avoided by adding the rule I pasted at the bottom:

Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { void login(java.lang.String,com.facebook.react.bridge.Promise); }', but not the descriptor class 'com.facebook.react.bridge.Promise'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { void logout(com.facebook.react.bridge.Promise); }', but not the descriptor class 'com.facebook.react.bridge.Promise'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { void getCurrentAccessToken(com.facebook.react.bridge.Promise); }', but not the descriptor class 'com.facebook.react.bridge.Promise'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { void getCurrentAccount(com.facebook.react.bridge.Promise); }', but not the descriptor class 'com.facebook.react.bridge.Promise'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { void configure(com.facebook.react.bridge.ReadableMap); }', but not the descriptor class 'com.facebook.react.bridge.ReadableMap'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { com.facebook.accountkit.ui.AccountKitConfiguration$AccountKitConfigurationBuilder createAccountKitConfiguration(com.facebook.accountkit.ui.LoginType); }', but not the descriptor class 'com.facebook.accountkit.ui.LoginType'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { com.facebook.react.bridge.WritableMap mapToken(com.facebook.accountkit.AccessToken); }', but not the descriptor class 'com.facebook.accountkit.AccessToken'
Note: the configuration keeps the entry point 'io.underscope.react.fbak.RNAccountKitModule { java.lang.String[] formatCountryList(com.facebook.react.bridge.ReadableArray); }', but not the descriptor class 'com.facebook.react.bridge.ReadableArray'

We need to add:

# facebook account kit
-keep class com.facebook.react.** { *; }
-keep class com.facebook.accountkit.** { *; }

to proguard-rules.txt

@gaguirre
Copy link
Collaborator

Hey @fabriziomoscon, thanks for the tip!
We could add it to the documentation, a PR would be great ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants