Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMoreRecipeConflict incompatibility with Disk Rack #678

Open
Slayer5934 opened this issue Aug 18, 2019 · 3 comments
Open

NoMoreRecipeConflict incompatibility with Disk Rack #678

Slayer5934 opened this issue Aug 18, 2019 · 3 comments

Comments

@Slayer5934
Copy link

https://paste.dimdev.org/muvihigupu.mccrash

@GotoLink
Copy link

GotoLink commented Aug 19, 2019

TileEntityDiskRack seems to be implementing both IInventory (minecraft) and IItemHandler (forge) interfaces for inventory management.
They define getStackInSlot(int)#ItemStack, but minecraft method will be obfuscated back in the production jar file, then IItemHandler contract will no longer be complete ("abstract" method)
Similar to #635 and #640 and #629 and #601 and #519

@AhiVT
Copy link

AhiVT commented Sep 8, 2019

@GotoLink Is it possible to propose a pseudocode solution to this bug? Perhaps I could write an implementation.

@GotoLink
Copy link

GotoLink commented Sep 9, 2019

Well basically remove the implements IItemHandler statement for every offending TileEntity classes.
Then override for TileEntity#getCapability(Capability, EnumFacing) :

if (capability == ITEM_HANDLER_CAPABILITY) return new InvWrapper((IInventory)this);

Or use the SidedInvWrapper if you want fancy sidedness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants