Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slash command support & custom messages to other stuff #64

Merged
merged 12 commits into from Sep 27, 2021

Conversation

ChopChoP534
Copy link
Collaborator

CHANGES:

Giveaways-
- Nuggies.giveaways.create({ message, prize, hostID, winners, endAfter, requirements = { enabled: false }, channelID })
+ Nuggies.giveaways.create(client, { prize, hostID, winners, endAfter, requirements = { enabled: false }, channel })

- Nuggies.giveaways.drop({ message, prize, channelID, hostID })
+ Nuggies.giveaways.drop(client, { prize, channel, hostID })

Button Roles-
- Nuggies.buttonroles.create({ message, role, content, channelID })
+ Nuggies.buttonroles.create(client, { content, role, channelID })

DropDown Role-
- Nuggies.dropdownroles.create({ message, role, content, channelID })
+ Nuggies.dropdownroles.create(client, { content, role, channelID })

Custom Messages Function-
- Nuggies.giveaways.Messages(client, {});
+ https://sourceb.in/w2BsAi6EZM it big

there can be some stuff that I forgor to mention

@LegItMate
Copy link
Collaborator

Typings aren't updated I suppose?

@LegItMate LegItMate added the enhancement New feature or request label Sep 6, 2021
@ChopChoP534
Copy link
Collaborator Author

nope, idk how to ts

@LegItMate LegItMate self-requested a review September 6, 2021 07:56
@LegItMate
Copy link
Collaborator

Will have to wait for me then

Copy link
Collaborator

@LegItMate LegItMate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At src/classes/v12/dropdownroles.js#3 you seem to have required client from src/classes/v13/dropdownroles.js and similar in that same file, but you are not exporting the client.

@ChopChoP534
Copy link
Collaborator Author

fixed

@LegItMate
Copy link
Collaborator

LegItMate commented Sep 7, 2021

At src/classes/v12/giveaways.js#57 you are using channel as a TextChannel/Channel but channel is supposed to be snowflake(or ID of the channel)

PS: Same is followed at src/classes/v12/giveaways.js#62

PS 2: The above is also the same for v13 and a new inclusion of drop function

PS 3: src/classes/v13/dropdownroles.js#47 Woops nevermind didn't see it correctly

@LegItMate LegItMate self-requested a review September 7, 2021 17:15
@LegItMate
Copy link
Collaborator

LegItMate commented Sep 8, 2021

ESLint throws an error in src/classes/v12/dropdownroles.js#48 which is message is not defined
image

PS: Kind of same error in src/classes/v13/dropdownroles.js#47
image

PS 2: I have fixed all the ESLint errors except for those above.

@Assassin-1234
Copy link
Member

can you import discord.js in src/typings/index.ts ? other than that I dont see a problem, @LegItMate merge if everything alryte 👍

@Assassin-1234
Copy link
Member

didnt meant to close oop

@LegItMate
Copy link
Collaborator

can you import discord.js in src/typings/index.ts ? other than that I dont see a problem, @LegItMate merge if everything alryte 👍

It isn't required/used though

@Assassin-1234
Copy link
Member

can you import discord.js in src/typings/index.ts ? other than that I dont see a problem, @LegItMate merge if everything alryte 👍

It isn't required/used though

eslint gives 69420 errrors

@Nuggies-bot Nuggies-bot deleted a comment from Monster3425 Sep 12, 2021
@Assassin-1234
Copy link
Member

stale or are typings being worked at?

@Assassin-1234 Assassin-1234 merged commit 35a1708 into Nuggies-bot:dev Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants