Minimal async support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using flume channels both for single responses and stream responses. The alternative would be to use a futures oneshot receiver, but that does not have a blocking option. What is great about flume is that it has a completely workable blocking and non-blocking API.
The async part is not as convenient as the sync support. E.g. all async fns have an _async suffix, and Response does not implement Stream. But you can use it without unneccessary spawn_blocking, and that's the main thing.
This is to minimize dependencies for the non async version: ❯ cargo tree --no-default-features | grep -C 10 flume mainline v0.2.0 (/Users/rklaehn/projects_git/mainline-rs) ├── crc v3.0.1 │ └── crc-catalog v2.4.0 ├── flume v0.11.0 │ ├── nanorand v0.7.0 │ │ └── getrandom v0.2.11 │ │ ├── cfg-if v1.0.0 │ │ └── libc v0.2.150 │ └── spin v0.9.8 │ └── lock_api v0.4.11 │ └── scopeguard v1.2.0 │ [build-dependencies] │ └── autocfg v1.1.0 ├── rand v0.8.5 ❯ cargo tree | grep -C 10 flume mainline v0.2.0 (/Users/rklaehn/projects_git/mainline-rs) ├── crc v3.0.1 │ └── crc-catalog v2.4.0 ├── flume v0.11.0 │ ├── futures-core v0.3.29 │ ├── futures-sink v0.3.29 │ ├── nanorand v0.7.0 │ │ └── getrandom v0.2.11 │ │ ├── cfg-if v1.0.0 │ │ └── libc v0.2.150 │ └── spin v0.9.8 │ └── lock_api v0.4.11 │ └── scopeguard v1.2.0 │ [build-dependencies]
also behind the feature gate. Not using tokio::test to avoid the dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use flume channels instead of std::mpsc channel to have the option to do async.
Expose a minimal async API under a feature flag, so you can avoid needless spawn_blocking to e.g. wait for a result.