Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV for v6 is Rust 1.59 #72

Closed
alpha-tango-kilo opened this issue Apr 2, 2022 · 2 comments · Fixed by #73
Closed

MSRV for v6 is Rust 1.59 #72

alpha-tango-kilo opened this issue Apr 2, 2022 · 2 comments · Fixed by #73
Assignees
Labels
t: bug Something isn't working

Comments

@alpha-tango-kilo
Copy link

First of all, please read the FAQ if you're having styling issues!

Otherwise feel free to go ahead :)

Describe the bug

The Cargo.toml for this library states that the MSRV is 1.58, but it can't currently compile on 1.58

Expected behavior

Cloning the repo and building it should work on 1.58 or the MSRV should be declared as 1.59

Code

N/A

Steps to reproduce the bug

> git checkout v6.0.0-rc.1
> rustup install 1.58 # if not already installed
> cargo +1.58 build

Error:

error[E0658]: destructuring assignments are unstable
  --> src\utils\arrangement\dynamic.rs:62:46
   |
62 |         (remaining_width, remaining_columns) = enforce_lower_boundary_constraints(
   |         ------------------------------------ ^
   |         |
   |         cannot assign to this expression
   |
   = note: see issue #71126 <https://github.com/rust-lang/rust/issues/71126> for more information

error[E0658]: destructuring assignments are unstable
  --> src\utils\arrangement\dynamic.rs:85:46
   |
85 |         (remaining_width, remaining_columns) = optimize_space_after_split(
   |         ------------------------------------ ^
   |         |
   |         cannot assign to this expression
   |
   = note: see issue #71126 <https://github.com/rust-lang/rust/issues/71126> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `comfy-table` due to 2 previous errors

Additional context

  • Operating System: Windows 10
  • comfy-table version: v6.0.0-rc.1
@alpha-tango-kilo alpha-tango-kilo added the t: bug Something isn't working label Apr 2, 2022
@Nukesor
Copy link
Owner

Nukesor commented Apr 3, 2022

Thanks for the report :)

The MSRV is now also covered by the CI. Any future breakages will be noticed.

@alpha-tango-kilo
Copy link
Author

Nice one, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants