Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch env in daemon tests #346

Merged
merged 3 commits into from Aug 12, 2022
Merged

Catch env in daemon tests #346

merged 3 commits into from Aug 12, 2022

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Aug 11, 2022

Previously, all tasks that were created in daemon tests had an empty envs field.

This lead to problem when running the tests in environments where sleep isn't located in the default $PATH.

By catching the correct $PATH from the environment, this change should fix those tests for these environments.

Part of #342

@Nukesor Nukesor added the t: Bug label Aug 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #346 (35448a4) into main (d4f7c25) will increase coverage by 0.09%.
The diff coverage is 83.33%.

❗ Current head 35448a4 differs from pull request most recent head a32a11d. Consider uploading reports for the commit a32a11d to get more accurate results

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   74.20%   74.30%   +0.09%     
==========================================
  Files          71       71              
  Lines        4858     4860       +2     
==========================================
+ Hits         3605     3611       +6     
+ Misses       1253     1249       -4     
Impacted Files Coverage Δ
client/client.rs 47.63% <83.33%> (+0.54%) ⬆️
client/display/mod.rs 42.85% <0.00%> (ø)
client/commands/mod.rs 87.50% <0.00%> (ø)
client/commands/wait.rs 0.00% <0.00%> (ø)
client/display/group.rs 100.00% <0.00%> (ø)
client/display/state.rs 70.61% <0.00%> (ø)
client/display/helper.rs 100.00% <0.00%> (ø)
client/commands/local_follow.rs 65.51% <0.00%> (ø)
client/main.rs 69.38% <0.00%> (+1.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nukesor Nukesor merged commit 7661f02 into main Aug 12, 2022
@Nukesor Nukesor deleted the catch-env-in-daemon-tests branch August 12, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants