Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config location "~/.config/pueue/pueue.yml" also for macOS #464

Closed
meseck opened this issue Sep 21, 2023 · 8 comments
Closed

Support config location "~/.config/pueue/pueue.yml" also for macOS #464

meseck opened this issue Sep 21, 2023 · 8 comments

Comments

@meseck
Copy link
Contributor

meseck commented Sep 21, 2023

A detailed description of the feature you would like to see added.

Also on macOS, the "~/.config" folder is essentially the "home folder" for config files for most CLI tools available today.

Explain your usecase of the requested feature

The "~/.config" folder is a very convenient place to manage and then back up your personal dotfiles.

Alternatives

I could symlink "~/Library/Application Support/pueue/pueue.yml" directory to "~/.config/pueue/pueue.yml".
But then I lose the portability of this config file to other Unix systems. :/

Additional context

No response

@Nukesor
Copy link
Owner

Nukesor commented Sep 23, 2023

Sadly, the .config location is not a standard in the MacOS environment, hence I would like to not support it.

However, you can easily achieve this by just using an alias and setting the configuration directory manually.

alias pueue='pueue -c ~/.config/pueue/pueue.yml'

@QuantumGhost
Copy link

Maybe add an environment variable PUEUE_CONFIG ?

@Nukesor
Copy link
Owner

Nukesor commented Sep 29, 2023

That sounds reasonable to me :)

Could you check out the linked MR? I went ahead and implemented the feature as requested.

@Nukesor
Copy link
Owner

Nukesor commented Oct 11, 2023

Ping @meseck

@meseck
Copy link
Contributor Author

meseck commented Oct 11, 2023

I really appreciate this solution. Thank you for your effort!

Just like how ripgrep handles this:
https://github.com/BurntSushi/ripgrep/blob/master/GUIDE.md#configuration-file

Just one small thing: to be super explicit that the environment variable expects a path (and not already config properties), what do you think of naming it PUEUE_CONFIG_PATH? This is also how ripgrep does it. :)

@Nukesor
Copy link
Owner

Nukesor commented Oct 11, 2023

I like that proposal. PUEUE_CONFIG has been renamed to PUEUE_CONFIG_PATH :)

@Nukesor Nukesor closed this as completed Oct 14, 2023
@texastoland
Copy link

texastoland commented Feb 1, 2024

Didn't make it into the readme/wiki 🫣

@Nukesor
Copy link
Owner

Nukesor commented Feb 1, 2024

Feel free to update the wiki :). Everybody can edit it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants