Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 blocks trace rendering support + Integrated PBR 1.21 blocks support #74

Open
ShrikerChestTrees opened this issue Mar 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@ShrikerChestTrees
Copy link

When you posted your commit that there is support for 1.21 blocks, I checked and everything works, but not the way it should, here are screenshots for examples:
2024-03-25_09 56 28
2024-03-25_09 57 23
So fix the block rendering from 1.21 and Integrated PBR for 1.21 blocks.
Thank you in advance.

@null511
Copy link
Contributor

null511 commented Mar 25, 2024

ah, I'm pretty sure I missed copper doors entirely, forgot they were added. thanks!

@null511 null511 added the bug Something isn't working label Mar 25, 2024
@null511
Copy link
Contributor

null511 commented Mar 25, 2024

I fixed copper doors & trapdoors in the latest commit, but what's the issue in that second pic?
it looks like a button, but afaik I added them all

@ShrikerChestTrees
Copy link
Author

ShrikerChestTrees commented Mar 25, 2024

I fixed copper doors & trapdoors in the latest commit, but what's the issue in that second pic?
it looks like a button, but afaik I added them all

It's not the button, it's the problem with the integrated PBR. What is glowing is a glowing copper block, which is not even reflected like other new blocks from 1.21.

@null511
Copy link
Contributor

null511 commented Mar 25, 2024

Can't do anything about the copper glowing, I am not going to be adding per-pixel IPBR like Emin did with Comp. For that you'll need a PBR RP.

I can fix the reflections though...

@ShrikerChestTrees
Copy link
Author

Can't do anything about the copper glowing, I am not going to be adding per-pixel IPBR like Emin did with Comp. For that you'll need a PBR RP.

I can fix the reflections though...

OK.
Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants