Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support bridge descriptors and consensus #13

Merged
merged 5 commits into from Oct 12, 2021

Conversation

meskio
Copy link
Contributor

@meskio meskio commented Oct 6, 2021

I add support into the consensus and the descriptor parsers for bridge file types.

I thought it was better to extend the existing parser and support both bridge/relay in a single struct type, but could be splited if you think it makes more sense. It should be fully backward compatible.

@meskio
Copy link
Contributor Author

meskio commented Oct 6, 2021

@NullHypothesis tell me what you think about it. This should cover our needs for rdsys for now.

Unsafe consensus files are the ones that doesn't contain annotations, as
they are provided by the directory authorities.
Copy link
Owner

@NullHypothesis NullHypothesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a small remark but looks good otherwise.

consensus.go Outdated Show resolved Hide resolved
@NullHypothesis NullHypothesis merged commit 017a7be into NullHypothesis:master Oct 12, 2021
@meskio
Copy link
Contributor Author

meskio commented Oct 12, 2021

Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants