Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle double letters #5

Closed
NullVoxPopuli opened this issue Jan 24, 2022 · 0 comments
Closed

Correctly handle double letters #5

NullVoxPopuli opened this issue Jan 24, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@NullVoxPopuli
Copy link
Owner

Reported here: https://twitter.com/andyhot/status/1485466040083619844?s=20

The issue occurs here: https://github.com/NullVoxPopuli/ember-wordle/blob/main/app/components/board/state/actions.ts#L108

So, because includes is used, if you guess double correct letters, they'll both have the same result (yellow or green), when a guess should only have one match per letter.

For example, if you guess apple, and the answer is pizza, only the first p in apple should be highlighted
@NullVoxPopuli NullVoxPopuli added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli