Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable lint rule for long hasMany lines #854

Open
CelticMajora opened this issue May 20, 2020 · 4 comments
Open

Reenable lint rule for long hasMany lines #854

CelticMajora opened this issue May 20, 2020 · 4 comments

Comments

@CelticMajora
Copy link
Collaborator

1st linting error:
Screenshot from 2020-05-19 20-25-17
Lines 18 and 19
Screenshot from 2020-05-19 20-25-37
Lines 11 and 12

1st linting error message: Insert new line

2nd linting error:
Screenshot from 2020-05-19 20-49-45
Screenshot from 2020-05-19 20-52-51

2nd linting error message: Expected @belongsTo to be inline/Expected @hasmany to be inline

These conflict in files:

  • packages/frontend/app/model/identity.ts
  • packages/frontend/app/model/channel-context-chain.ts

Code for these are in #853

@NullVoxPopuli
Copy link
Owner

Related: NullVoxPopuli/eslint-plugin-decorator-position#34

for now, you'll need to disable the lint rule for those hasMany lines, which vs code should have an autofixer for ya

@CelticMajora
Copy link
Collaborator Author

Would you prefer it be one line or two?

@NullVoxPopuli
Copy link
Owner

doesn't matter, just tell eslint to disable for next line ;)

@NullVoxPopuli NullVoxPopuli changed the title Disable lint rule for long hasMany lines Reenable lint rule for long hasMany lines May 25, 2020
@NullVoxPopuli
Copy link
Owner

Changed the title for when this lands
NullVoxPopuli/eslint-plugin-decorator-position#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants