Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pl] Wrong ordinal spelling? #40

Open
tengwar opened this issue Sep 23, 2018 · 4 comments
Open

[pl] Wrong ordinal spelling? #40

tengwar opened this issue Sep 23, 2018 · 4 comments

Comments

@tengwar
Copy link

tengwar commented Sep 23, 2018

I'm using the online demo. In Polish it spells 75 as "siedemdziesiąt piąty" and 44 as "czterdzieści czwarty". I'm not a language expert but everyone I know says "siedemdziesiąty piąty" and "czterdziesty czwarty". When I try just 70 or 40, the results are correct ("siedemdziesiąty" and "czterdziesty").

(For feminine and neuter forms it would be "siedemdziesiąta piąta" and "siedemdziesiąte piąte" respectively.)

@laszlonemeth
Copy link
Contributor

Fixed in the data file, and it will be fixed also on the demo page soon. Thanks for your bug report.

@tengwar
Copy link
Author

tengwar commented Oct 9, 2018

I see you've added cases for "-eści" and "-siąt" but there's also "dwadzieścia", for example "dwadzieścia dwa" (22) - "dwudziesty drugi" (22nd).

And by testing this i noticed another issue: ordinal of 20 shows as "dwadziesty" but it should be "dwudziesty".

I've also noticed potential issues with larger numbers, e.g. ordinal of 200 000 shows as "dwieścietysięczny" but I'm not sure if it should be "dwustutysięczny" (which is in common use) or "dwieście tysięczny" which - as some guy argues here - is correct according to general rules of ordinals. I guess a language specialist should take a look at it.

@laszlonemeth laszlonemeth reopened this Oct 9, 2018
@laszlonemeth
Copy link
Contributor

Thanks, I have reopened this issue, many thanks for the detailed source.

@tengwar
Copy link
Author

tengwar commented Oct 10, 2018

The source seems more like "what is theoretically correct according to general grammar rules", not "what people are actually using" and not "what is in the dictionaries". That's why I said a language specialist should take a look at it.

But I'm certain when it comes to the "20" issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants