Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing edit, clear all, updating status #11

Merged
merged 2 commits into from Oct 13, 2022
Merged

Testing edit, clear all, updating status #11

merged 2 commits into from Oct 13, 2022

Conversation

NurkaAmre
Copy link
Owner

Testing edit, updating status,clear all completed:

  • An executed unit test case for editing the task description function.
  • An executed unit test case for updating an item's 'completed' status function.
  • An executed unit test case for the "Clear all completed" function.

Copy link

@Abenezer-Tilahun Abenezer-Tilahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NurkaAmre ,

Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 👏🏻

✔️ No linter errors.
✔️ You used correct Github Flow.
✔️ Professional README
✔️ Good Commit Messages

Optional suggestions

  • Please try to fix the MIT License in your README File.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NurkaAmre
Copy link
Owner Author

Thank you for reviewing our code.

@NurkaAmre NurkaAmre merged commit 95b6eb1 into master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants