Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to watch anime from torrent inside app #5

Closed
xdk78 opened this issue Jul 2, 2017 · 19 comments
Closed

Possibility to watch anime from torrent inside app #5

xdk78 opened this issue Jul 2, 2017 · 19 comments
Milestone

Comments

@xdk78
Copy link
Contributor

xdk78 commented Jul 2, 2017

What do u think about this?
I would like to use https://github.com/TorrentStream/TorrentStream-Android library or something like that to download/watch videos and other shit from torrrent inside app 馃槃 馃槃 馃槃 馃槃

@akuma06
Copy link
Member

akuma06 commented Jul 2, 2017

Yeah seems quite good actually (and easy to implement).
The workflow would be to have a fragment "downloads" listing the downlads/options to delete/stop a torrent. And when you want to add a download, you just start the fragment with the torrent url?

That might be a great improvement on the app :D

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 2, 2017

you just start the fragment with the torrent url?

This seems good: https://github.com/TorrentStream/TorrentStream-Android/blob/develop/sample/src/main/java/com/github/se_bastiaan/torrentstreamer/sample/MainActivity.java
For now just like that
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(torrent.getVideoFile().toString())); intent.setDataAndType(Uri.parse(torrent.getVideoFile().toString()), "video/mp4"); startActivity(intent);
or write video player for this

@akuma06
Copy link
Member

akuma06 commented Jul 2, 2017

Sorry I didn't get the real intent of the library. It's a torrent player? Cool, then you don't actually have to do the torrent workflow =D. Just need to start the library intent :)

However, might be interesting to add a fragment with the "recently payed stuff" or a "Playlist", so you don't have to do the search everytime.

To have the torrentlist, you would only need to copy how to create a torrent list object : KotprefModel() with some torrents property (json array?). And then we only add a torrent to the list at the same time we start the intent?

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 2, 2017

It's a torrent player?

yes 馃槄 sorry for misunderstood

However, might be interesting to add a fragment with the "recently payed stuff" or a "Playlist", so you don't have to do the search everytime

good idea

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 2, 2017

Just add magnet or .torrent and torrent.getVideoFile().toString()), "video/mp4"
that's it!

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 2, 2017

In free time I want start write and test basic stuff for app.

@akuma06
Copy link
Member

akuma06 commented Jul 2, 2017

Yeah you can :). I can't help you for now (I'm on the refactoring of NyaaPantsu main website) but if you need help, ask here or on IRC =)

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 3, 2017

So, I just little improved app code and almost finished writing basic video streaming from .torrent

@akuma06
Copy link
Member

akuma06 commented Jul 3, 2017

Oh neat! :D For my part I'm stuck on CSRF validation in refactoring :')

@akuma06
Copy link
Member

akuma06 commented Jul 3, 2017

I've gone through your code. It's really good! Sorry for not having done activities/fragments separation and all, it was done a bit in a hurry :p.
I just have a question so far, why do you think it is better to have a minSdk to 21? I think 19 might be better since we would target kitkat as well. (https://developer.android.com/about/dashboards/index.html)

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 3, 2017

app using material design(i know, it's compatible with 19) so I think it's time to use super new tech features from sdk 21+ without preparing for old phones.
btw STREAMING WORKING!!! 馃槃
now im adding ProgressDialog 馃槃 to show progress buffering, when stream is ready.

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 3, 2017

Some screen shots

http://imgur.com/rrp36Ty

http://imgur.com/2bOyx8v
and after that opening Intent chooser, u can choose video plaayer for example mx player

@akuma06
Copy link
Member

akuma06 commented Jul 3, 2017

Great =D. This might come the most used app on my phone now =D

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 3, 2017

Thx. Now it's time to upgrade this shit code. It would be nice if you help me :)

@akuma06
Copy link
Member

akuma06 commented Jul 3, 2017

I will, don't worry :). Just need to finish my own work before ^^

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 3, 2017

Btw I want to assign myself to more issues, could u add me to contributors with access to this repo?

@xdk78
Copy link
Contributor Author

xdk78 commented Jul 5, 2017

I'm rewriting adapters from BaseAdapter to RecyclerView for better control and more features

edit:
I have some issues(im not good to convert my java skills to kotlin 馃槃 ) https://github.com/xdk78/NyaaPantsu-android-app/commit/076c6e68070ac9661f3e4978176698ac6e437d2e
If u have moment pls look

@akuma06
Copy link
Member

akuma06 commented Jul 6, 2017

@xdk78 Didn't see your comments on this issue. For the contributor access, I have to ask @ewhal for that, I can't take a decision :).
Will take a look to recycler view conversion :)

@akuma06 akuma06 added this to the v1.1 milestone Jul 6, 2017
@akuma06
Copy link
Member

akuma06 commented Jul 6, 2017

We should close this issue (since we now have anime streaming) and keep things ordered. If you need some help, open a new issue, that would be better I think =)

@akuma06 akuma06 closed this as completed Jul 6, 2017
@akuma06 akuma06 mentioned this issue Jul 7, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants